Bug 145219

Summary:

No LLInt Test Failure: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

JavaScriptCore

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, joepeck, mark.lam, msaboff

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	mark.lam: review+

Description Joseph Pecoraro 2015-05-20 12:29:51 PDT

Bots are seeing a JSC test failure.
https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/10187/steps/webkit-32bit-jsc-test/logs/stdio
FAIL: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint

Diff looks like:

> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: DIFF FAILURE!
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: --- ../.tests/jsc-layout-tests.yaml/js/object-literal-duplicate-properties-expected.txt	2015-05-20 11:06:14.000000000 -0700
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +++ ../jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint.out	2015-05-20 11:19:37.000000000 -0700
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: @@ -224,19 +224,19 @@
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint:  PASS (function(){var __proto__ = null; o = {__proto__:null, __proto__}})() did not throw exception.
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint:  PASS ({__proto__:[], __proto__:{}}) threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint:  PASS 'use strict';({__proto__:[], __proto__:{}}) threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: -PASS (function(){({__proto__:[], __proto__:{}})})() threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +PASS (function(){({__proto__:[], __proto__:{}})})() threw exception RangeError: Maximum call stack size exceeded..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint:  PASS o = {__proto__:null, '__proto__':{}} threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint:  PASS 'use strict';o = {__proto__:null, '__proto__':{}} threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: -PASS (function(){o = {__proto__:null, '__proto__':{}}})() threw exception SyntaxError: Attempted to redefine __proto__ property..
> jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint: +PASS (function(){o = {__proto__:null, '__proto__':{}}})() threw exception RangeError: Maximum call stack size exceeded..
> ...

Note the different exception message.

Comment 1 Joseph Pecoraro 2015-05-20 12:31:16 PDT

Created attachment 253457 [details]
[PATCH] Proposed Fix

Comment 2 Mark Lam 2015-05-20 12:32:27 PDT

Comment on attachment 253457 [details]
[PATCH] Proposed Fix

r=me

Comment 3 Joseph Pecoraro 2015-05-20 12:35:55 PDT

http://trac.webkit.org/changeset/184647