Bug 145217

Summary:

ThreadableLoaderOptions::isolatedCopy() doesn't produce a copy that is safe for sending to another thread

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Page Loading

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=143790

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-05-20 11:46:52 PDT

ThreadableLoaderOptions contains an AtomicString, so even an isolated copy cannot be sent to another thread.

Comment 1 Alexey Proskuryakov 2015-05-20 11:50:40 PDT

Created attachment 253453 [details]
proposed fix

Comment 2 Anders Carlsson 2015-05-20 12:14:38 PDT

Comment on attachment 253453 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253453&action=review

> Source/WebCore/loader/ThreadableLoader.h:71
> +        String initiator; // This cannot be an AtomicString, as isolatedCopy() wouldn't create an object that's safe for passing to another thread.

I think this comment would be better as a ChangeLog comment - no real point in listing what types a member variable cannot be.

Comment 3 Alexey Proskuryakov 2015-05-20 13:32:16 PDT

Comment on attachment 253453 [details]
proposed fix

I'm sure someone would change this back into an AtomicString within a week from now, and there is no better way to prevent that than a header comment, unfortunately.

Comment 4 WebKit Commit Bot 2015-05-20 14:08:34 PDT

Comment on attachment 253453 [details]
proposed fix

Clearing flags on attachment: 253453

Committed r184657: <http://trac.webkit.org/changeset/184657>

Comment 5 WebKit Commit Bot 2015-05-20 14:08:38 PDT

All reviewed patches have been landed.  Closing bug.