Bug 145213

Summary: Eden collections should extend the IncrementalSweeper work list, not replace it.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mhahnenb
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2015-05-20 10:46:17 PDT
<rdar://problem/21002666>
Attachments
Patch (5.53 KB, patch)
2015-05-20 11:00 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2015-05-20 11:07 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-20 11:00:43 PDT
Created attachment 253447 [details] Patch
Andreas Kling
Comment 2 2015-05-20 11:07:20 PDT
Created attachment 253449 [details] Patch
Geoffrey Garen
Comment 3 2015-05-20 11:13:42 PDT
Comment on attachment 253449 [details] Patch r=me
Geoffrey Garen
Comment 4 2015-05-20 11:22:38 PDT
It's strange that a bug in the incremental sweeper could cause runaway memory use. By design, each new object allocated should sweep an old object freed. The incremental sweeper is supposed to be an optimization, not an essential way to avoid runaway memory use.
WebKit Commit Bot
Comment 5 2015-05-20 13:30:51 PDT
Comment on attachment 253449 [details] Patch Clearing flags on attachment: 253449 Committed r184652: <http://trac.webkit.org/changeset/184652>
WebKit Commit Bot
Comment 6 2015-05-20 13:30:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.