Bug 145213

Summary:

Eden collections should extend the IncrementalSweeper work list, not replace it.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, mhahnenb

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andreas Kling 2015-05-20 10:46:17 PDT

<rdar://problem/21002666>

Comment 1 Andreas Kling 2015-05-20 11:00:43 PDT

Created attachment 253447 [details]
Patch

Comment 2 Andreas Kling 2015-05-20 11:07:20 PDT

Created attachment 253449 [details]
Patch

Comment 3 Geoffrey Garen 2015-05-20 11:13:42 PDT

Comment on attachment 253449 [details]
Patch

r=me

Comment 4 Geoffrey Garen 2015-05-20 11:22:38 PDT

It's strange that a bug in the incremental sweeper could cause runaway memory use. By design, each new object allocated should sweep an old object freed. The incremental sweeper is supposed to be an optimization, not an essential way to avoid runaway memory use.

Comment 5 WebKit Commit Bot 2015-05-20 13:30:51 PDT

Comment on attachment 253449 [details]
Patch

Clearing flags on attachment: 253449

Committed r184652: <http://trac.webkit.org/changeset/184652>

Comment 6 WebKit Commit Bot 2015-05-20 13:30:54 PDT

All reviewed patches have been landed.  Closing bug.