Bug 145154 – [EFL] Use GSimpleProxyResolver instead of custom SoupProxyResolver

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

SoupProxyResolver was deprecated since 2.28
Now, we are using libsoup 2.42

[Ryuan Choi]

Created attachment 253355 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 253355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review

> Source/WebCore/ChangeLog:15
> +        * platform/network/soup/ProxyResolverSoup.cpp: Removed.

Doesn't Win port still use this file ?

Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

[Ryuan Choi]

Created attachment 253372 [details]
Patch

[Ryuan Choi]

Created attachment 253373 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 253355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review

>> Source/WebCore/ChangeLog:15
>> +        * platform/network/soup/ProxyResolverSoup.cpp: Removed.
> 
> Doesn't Win port still use this file ?
> 
> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

I think nor Apple Windows, neither WinCairo port used SOUP ever, but there 
was an experiment to do it 2 years before - https://trac.webkit.org/changeset/166506 .
But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I right?

[Ryuan Choi]

(In reply to comment #5)
> Comment on attachment 253355 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253355&action=review
> 
> >> Source/WebCore/ChangeLog:15
> >> +        * platform/network/soup/ProxyResolverSoup.cpp: Removed.
> > 
> > Doesn't Win port still use this file ?
> > 
> > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
> 
> I think nor Apple Windows, neither WinCairo port used SOUP ever, but there 
> was an experiment to do it 2 years before -
> https://trac.webkit.org/changeset/166506 .
> But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I
> right?

Although windows port have a plan to use SOUP, I don't think that ProxyResolverSoup.cpp is required anymore because WebCore.vcxproj still contains SoupNetworkSession.cpp which covers the functionality of ProxyResolverSoup in this patch.

[Ryuan Choi]

Created attachment 253413 [details]
Patch

[Alex Christensen]

(In reply to comment #5)
> I think nor Apple Windows, neither WinCairo port used SOUP ever, but there 
> was an experiment to do it 2 years before -
> https://trac.webkit.org/changeset/166506 .
> But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I
> right?
I'm pretty sure I'm the only one who has ever experimented with SOUP on Windows.  GStreamer on Windows uses libsoup, but they used a version that was too old to link with WebKit, and I never got it to actually load anything.  I think it could be done, but that should not affect decisions in WebKit right now.  The WinCairo port uses CURL because of its license IIRC

[Gyuyoung Kim]

Comment on attachment 253413 [details]
Patch

Thank Alex, r=me.

[Ryuan Choi]

Comment on attachment 253413 [details]
Patch

Thanks.

[WebKit Commit Bot]

Comment on attachment 253413 [details]
Patch

Clearing flags on attachment: 253413

Committed r184610: <http://trac.webkit.org/changeset/184610>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryuan Choi]

*** Bug 113587 has been marked as a duplicate of this bug. ***