| Summary: | [EFL] Use GSimpleProxyResolver instead of custom SoupProxyResolver | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, bartosh, commit-queue, lucas.de.marchi, ossy | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 145127 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ryuan Choi
2015-05-18 17:15:09 PDT
Created attachment 253355 [details]
Patch
Comment on attachment 253355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review > Source/WebCore/ChangeLog:15 > + * platform/network/soup/ProxyResolverSoup.cpp: Removed. Doesn't Win port still use this file ? Source/WebCore/WebCore.vcxproj/WebCore.vcxproj Created attachment 253372 [details]
Patch
Created attachment 253373 [details]
Patch
Comment on attachment 253355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review >> Source/WebCore/ChangeLog:15 >> + * platform/network/soup/ProxyResolverSoup.cpp: Removed. > > Doesn't Win port still use this file ? > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj I think nor Apple Windows, neither WinCairo port used SOUP ever, but there was an experiment to do it 2 years before - https://trac.webkit.org/changeset/166506 . But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I right? (In reply to comment #5) > Comment on attachment 253355 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253355&action=review > > >> Source/WebCore/ChangeLog:15 > >> + * platform/network/soup/ProxyResolverSoup.cpp: Removed. > > > > Doesn't Win port still use this file ? > > > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj > > I think nor Apple Windows, neither WinCairo port used SOUP ever, but there > was an experiment to do it 2 years before - > https://trac.webkit.org/changeset/166506 . > But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I > right? Although windows port have a plan to use SOUP, I don't think that ProxyResolverSoup.cpp is required anymore because WebCore.vcxproj still contains SoupNetworkSession.cpp which covers the functionality of ProxyResolverSoup in this patch. Created attachment 253413 [details]
Patch
(In reply to comment #5) > I think nor Apple Windows, neither WinCairo port used SOUP ever, but there > was an experiment to do it 2 years before - > https://trac.webkit.org/changeset/166506 . > But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I > right? I'm pretty sure I'm the only one who has ever experimented with SOUP on Windows. GStreamer on Windows uses libsoup, but they used a version that was too old to link with WebKit, and I never got it to actually load anything. I think it could be done, but that should not affect decisions in WebKit right now. The WinCairo port uses CURL because of its license IIRC Comment on attachment 253413 [details]
Patch
Thank Alex, r=me.
Comment on attachment 253413 [details]
Patch
Thanks.
Comment on attachment 253413 [details] Patch Clearing flags on attachment: 253413 Committed r184610: <http://trac.webkit.org/changeset/184610> All reviewed patches have been landed. Closing bug. *** Bug 113587 has been marked as a duplicate of this bug. *** |