Bug 145149 – [Mac] All font lookups are flakey

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Myles C. Maxfield]

On all OSes.

[Myles C. Maxfield]

Created attachment 253350 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 253350 [details]
Patch

Clearing flags on attachment: 253350

Committed r184532: <http://trac.webkit.org/changeset/184532>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Myles C. Maxfield]

Reopened for the root cause.

[Myles C. Maxfield]

Fails when run after jquery/offset.html

[Myles C. Maxfield]

Reduction of the font-weights test: <div style="font-family: HelveticaNeue-Light; font-weight: 100;">Font: HelveticaNeue-Light Weight: 100</div>

[Myles C. Maxfield]

reduction of the offset test:
<script>
testRunner.waitUntilDone()
window.setTimeout(function() {
    testRunner.notifyDone();
}, 13);
</script>
<h2 style="font-family: HelveticaNeue-Light;">asdf

[Myles C. Maxfield]

Running the test alone uses HelveticaNeue-Light, while running the two together uses HelveticaNeue-UltraLight

[Myles C. Maxfield]

This is because the desiredFamilyToAvailableFamilyDictionary() cache inside fontWithFamily() in FontCacheMac is incorrect.

In particular, there are two exit points of this function. If our search item exists in the cache, we skip the first exit point, which may be the correct one to take.

A previous font may have skipped over the first exit point because of external information (weight, traits, etc). Because of this, we will insert this name into the cache. However, when the second font comes around, its external information may mean that it should take the first exit point. However, we notice that the family name is in the cache and skip the first exit point.

[Myles C. Maxfield]

See https://bugs.webkit.org/show_bug.cgi?id=137539

[Myles C. Maxfield]

platform/mac/fast/text/font-weights.html is the test in question.

[Myles C. Maxfield]

<rdar://problem/21012406>

[Myles C. Maxfield]

Fixed in https://bugs.webkit.org/show_bug.cgi?id=145180