Summary: | Add full URL view on mouseOver in the network page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oncleben31 <oncleben31> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aroben, timothy | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 523.x (Safari 3) | ||||||||||
Hardware: | All | ||||||||||
OS: | OS X 10.4 | ||||||||||
Attachments: |
|
Description
Oncleben31
2007-07-03 11:38:03 PDT
Created attachment 15370 [details]
Patch to have the full URL on mouseOver
Patch to have the full URL on mouseOver just with CSS and HTML hack
Comment on attachment 15370 [details]
Patch to have the full URL on mouseOver
It would probably good to have a 1px border around the em.
Comment on attachment 15370 [details]
Patch to have the full URL on mouseOver
Please make sure to include you set the EMAIL_ADDRESS environment variable before creating the ChangeLog and to fill in the ChangeLog with information such as the bugzilla url and title and summary of changes made.
If you just set a title attribute on the .network-file element, a tooltip will appear automatically. Then you don't need your "CSS and HTML hack" This is what we do for resources in the left sidebar, so it'll have the added benefit of being consistent with other parts of the UI. Why not just use a title attribute on the link to get a tooltip for free? This will match what we already do for the sidebar. /me should read comments before he comments. > If you just set a title attribute on the .network-file element, a tooltip will
> appear automatically. Then you don't need your "CSS and HTML hack"
Using tooltip was my first idea but they doesn't appeared in my Safari (on my mac and on Windows), I've search in the preference : nothing. I search on Internet and I found "defaults write com.apple.Safari WebKitShowsURLsInToolTips 1"
This trick doesn't seem to work on Safari for Windows, I've to test on a mac.
If user have to hack Webkit to have tooltip working, I think my solution is better. Moreover my solution allow to debate and find the best CSS design for the tool tip (color, position).
What is you point of view ?
(In reply to comment #8) > Using tooltip was my first idea but they doesn't appeared in my Safari (on my > mac and on Windows) Tooltips should work fine in Safari on OS X. Tooltips are not yet supported in Safari on Windows (see bug 14143). This will eventually be fixed, so I still believe the title attribute is the right way to go. Created attachment 15393 [details]
Update of Patch to add ChangeLog info
In reponse of comment
I agree with Adam that this should use the title="" attribute. Please try a fix along those lines. Comment on attachment 15393 [details]
Update of Patch to add ChangeLog info
Please change to using a title attribute for consistency with the existing UI.
Created attachment 18793 [details]
patch
Comment on attachment 18793 [details]
patch
r=me
Committed revision 29901. |