Bug 145125

Summary:

Suppress null-conversion warnings in ANGLE

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

145010

Bug Blocks:

145121

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-05-18 03:28:59 PDT

./glslang_lex.cpp:1282:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2463:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2490:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2640:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2649:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2665:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2673:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2857:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2870:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2932:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:2947:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./glslang_lex.cpp:3112:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
12 warnings generated.

./Tokenizer.cpp:848:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1604:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1631:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1781:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1790:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1806:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1814:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:1998:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:2011:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:2073:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:2088:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
./Tokenizer.cpp:2253:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]
12 warnings generated.

We should fix it after ANGLE update - bug145010 .

Comment 1 Alex Christensen 2015-05-20 09:58:53 PDT

I assume this is from gcc.  Is there an equivalent of #pragma clang diagnostic ignored "-Wnull-conversion"?  I don't think we want to actually change this generated code.

Comment 2 Csaba Osztrogonác 2015-05-21 01:42:44 PDT

No, it is clang warning.

Comment 3 Csaba Osztrogonác 2015-06-18 05:56:08 PDT

Let's suppress this warning instead of changing 3rdparty source.

Comment 4 Csaba Osztrogonác 2015-06-18 05:57:23 PDT

Created attachment 255110 [details]
Patch

Comment 5 WebKit Commit Bot 2015-06-18 10:55:51 PDT

Comment on attachment 255110 [details]
Patch

Clearing flags on attachment: 255110

Committed r185707: <http://trac.webkit.org/changeset/185707>

Comment 6 WebKit Commit Bot 2015-06-18 10:55:54 PDT

All reviewed patches have been landed.  Closing bug.