Bug 145112 – Purge PassRefPtr in WebCore/Modules

• Component: New Bugs
• Status: RESOLVED FIXED

[Gyuyoung Kim]

SSIA

[Gyuyoung Kim]

Created attachment 253300 [details]
Patch

[Gyuyoung Kim]

Created attachment 253302 [details]
Patch

[Darin Adler]

Comment on attachment 253302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253302&action=review

> Source/WebCore/Modules/geolocation/PositionOptions.h:36
> +    static Ref<PositionOptions> create() { return adoptRef(*new PositionOptions()); }

I like to omit the unneeded parentheses in cases like this.

> Source/WebCore/Modules/mediastream/RTCDataChannel.h:51
> +    static RefPtr<RTCDataChannel> create(ScriptExecutionContext*, RTCPeerConnectionHandler*, const String& , const Dictionary&, ExceptionCode&);

Stray space after "const String&". Also, it makes no sense to omit the argument name for the string and dictionary; the types alone do not make it clear what these are!

> Source/WebCore/Modules/websockets/WebSocket.cpp:159
> +RefPtr<WebSocket> WebSocket::create(ScriptExecutionContext& context)

Should be Ref, not RefPtr.

> Source/WebCore/Modules/websockets/WebSocket.h:57
> +    static RefPtr<WebSocket> create(ScriptExecutionContext&);

Should be Ref, not RefPtr.

[Gyuyoung Kim]

Created attachment 253498 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #3)
> Comment on attachment 253302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253302&action=review
> 
> > Source/WebCore/Modules/geolocation/PositionOptions.h:36
> > +    static Ref<PositionOptions> create() { return adoptRef(*new PositionOptions()); }
> 
> I like to omit the unneeded parentheses in cases like this.
> 
> > Source/WebCore/Modules/mediastream/RTCDataChannel.h:51
> > +    static RefPtr<RTCDataChannel> create(ScriptExecutionContext*, RTCPeerConnectionHandler*, const String& , const Dictionary&, ExceptionCode&);
> 
> Stray space after "const String&". Also, it makes no sense to omit the
> argument name for the string and dictionary; the types alone do not make it
> clear what these are!
> 
> > Source/WebCore/Modules/websockets/WebSocket.cpp:159
> > +RefPtr<WebSocket> WebSocket::create(ScriptExecutionContext& context)
> 
> Should be Ref, not RefPtr.
> 
> > Source/WebCore/Modules/websockets/WebSocket.h:57
> > +    static RefPtr<WebSocket> create(ScriptExecutionContext&);
> 
> Should be Ref, not RefPtr.

All fixed.

[WebKit Commit Bot]

Comment on attachment 253498 [details]
Patch for landing

Clearing flags on attachment: 253498

Committed r184709: <http://trac.webkit.org/changeset/184709>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.