Bug 145112

Summary:

Purge PassRefPtr in WebCore/Modules

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144092

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Gyuyoung Kim 2015-05-17 17:42:53 PDT

SSIA

Comment 1 Gyuyoung Kim 2015-05-17 17:44:11 PDT

Created attachment 253300 [details]
Patch

Comment 2 Gyuyoung Kim 2015-05-17 22:24:48 PDT

Created attachment 253302 [details]
Patch

Comment 3 Darin Adler 2015-05-20 08:51:55 PDT

Comment on attachment 253302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253302&action=review

> Source/WebCore/Modules/geolocation/PositionOptions.h:36
> +    static Ref<PositionOptions> create() { return adoptRef(*new PositionOptions()); }

I like to omit the unneeded parentheses in cases like this.

> Source/WebCore/Modules/mediastream/RTCDataChannel.h:51
> +    static RefPtr<RTCDataChannel> create(ScriptExecutionContext*, RTCPeerConnectionHandler*, const String& , const Dictionary&, ExceptionCode&);

Stray space after "const String&". Also, it makes no sense to omit the argument name for the string and dictionary; the types alone do not make it clear what these are!

> Source/WebCore/Modules/websockets/WebSocket.cpp:159
> +RefPtr<WebSocket> WebSocket::create(ScriptExecutionContext& context)

Should be Ref, not RefPtr.

> Source/WebCore/Modules/websockets/WebSocket.h:57
> +    static RefPtr<WebSocket> create(ScriptExecutionContext&);

Should be Ref, not RefPtr.

Comment 4 Gyuyoung Kim 2015-05-20 20:02:04 PDT

Created attachment 253498 [details]
Patch for landing

Comment 5 Gyuyoung Kim 2015-05-20 23:37:38 PDT

(In reply to comment #3)
> Comment on attachment 253302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253302&action=review
> 
> > Source/WebCore/Modules/geolocation/PositionOptions.h:36
> > +    static Ref<PositionOptions> create() { return adoptRef(*new PositionOptions()); }
> 
> I like to omit the unneeded parentheses in cases like this.
> 
> > Source/WebCore/Modules/mediastream/RTCDataChannel.h:51
> > +    static RefPtr<RTCDataChannel> create(ScriptExecutionContext*, RTCPeerConnectionHandler*, const String& , const Dictionary&, ExceptionCode&);
> 
> Stray space after "const String&". Also, it makes no sense to omit the
> argument name for the string and dictionary; the types alone do not make it
> clear what these are!
> 
> > Source/WebCore/Modules/websockets/WebSocket.cpp:159
> > +RefPtr<WebSocket> WebSocket::create(ScriptExecutionContext& context)
> 
> Should be Ref, not RefPtr.
> 
> > Source/WebCore/Modules/websockets/WebSocket.h:57
> > +    static RefPtr<WebSocket> create(ScriptExecutionContext&);
> 
> Should be Ref, not RefPtr.

All fixed.

Comment 6 WebKit Commit Bot 2015-05-21 00:27:18 PDT

Comment on attachment 253498 [details]
Patch for landing

Clearing flags on attachment: 253498

Committed r184709: <http://trac.webkit.org/changeset/184709>

Comment 7 WebKit Commit Bot 2015-05-21 00:27:22 PDT

All reviewed patches have been landed.  Closing bug.