Bug 145102

Summary: [JSC] Make StringRecursionChecker faster in the simple cases without any recursion
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2015-05-16 17:11:55 PDT
[JSC] Make StringRecursionChecker faster in the simple cases without any recursion
Attachments
Patch (17.13 KB, patch)
2015-05-16 17:19 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-05-16 17:19:31 PDT
Created attachment 253281 [details] Patch
Darin Adler
Comment 2 2015-05-17 09:47:02 PDT
Comment on attachment 253281 [details] Patch I really like this optimization. I wish, however, that instead of custom code we had a class that was “HashSet plus single element kept outside the set”. Then this fix would just be changing the class name from HashSet to that new class. In theory. If the class was designed and implemented tightly enough. I’d really like to be able to apply this kind of optimization trivially in various places.
Benjamin Poulain
Comment 3 2015-05-17 18:10:43 PDT
(In reply to comment #2) > Comment on attachment 253281 [details] > Patch > > I really like this optimization. > > I wish, however, that instead of custom code we had a class that was > “HashSet plus single element kept outside the set”. Then this fix would just > be changing the class name from HashSet to that new class. In theory. If the > class was designed and implemented tightly enough. I’d really like to be > able to apply this kind of optimization trivially in various places. I believe Alex is working on that.
Benjamin Poulain
Comment 4 2015-05-17 23:23:35 PDT
Comment on attachment 253281 [details] Patch Clearing flags on attachment: 253281 Committed r184447: <http://trac.webkit.org/changeset/184447>
Benjamin Poulain
Comment 5 2015-05-17 23:23:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.