Bug 145079

Summary: REGRESSION (r183300): Background missing on top links on apple.com
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145087    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2015-05-15 16:20:32 PDT
REGRESSION (r183300): Background missing on top links on apple.com
Attachments
Patch (7.98 KB, patch)
2015-05-15 16:22 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-05-15 16:22:25 PDT
Created attachment 253238 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-05-15 16:22:48 PDT
rdar://problem/20914252
Simon Fraser (smfr)
Comment 3 2015-05-15 16:31:25 PDT
https://trac.webkit.org/r184421
Ryosuke Niwa
Comment 4 2015-05-15 18:33:23 PDT
Looks like this patch introduced 42 new layout test failures: e.g. https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r184421%20(12839)/results.html https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r184421%20(11805)/results.html https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r184421%20(4704)/results.html https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r184421%20(4365)/results.html Most of diffs look like this: --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/compositing/contents-scale/animating-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/compositing/contents-scale/animating-actual.txt @@ -4,7 +4,7 @@ (bounds 800.00 600.00) (visible rect 0.00, 0.00 800.00 x 600.00) (coverage rect 0.00, 0.00 800.00 x 600.00) - (intersects coverage rect 1) + (intersects coverage rect 0) (contentsScale 1.00) (children 1 (GraphicsLayer @@ -12,7 +12,7 @@ (contentsOpaque 1) (visible rect 0.00, 0.00 800.00 x 600.00) (coverage rect 0.00, 0.00 800.00 x 600.00) - (intersects coverage rect 1) + (intersects coverage rect 0) (contentsScale 1.00) (children 1 (GraphicsLayer @@ -24,7 +24,7 @@ (transform [1.50 0.00 0.00 0.00] [0.00 1.50 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 0.00 1.00]) (visible rect 0.00, 0.00 100.00 x 100.00) (coverage rect -12.00, -6.67 533.33 x 400.00) - (intersects coverage rect 1) + (intersects coverage rect 0) (contentsScale 1.00) ) )
WebKit Commit Bot
Comment 5 2015-05-15 18:33:46 PDT
Re-opened since this is blocked by bug 145087
Simon Fraser (smfr)
Comment 6 2015-05-15 21:27:10 PDT
https://trac.webkit.org/changeset/184430
Note You need to log in before you can comment on or make changes to this bug.