Bug 145073

Summary:

Web Inspector: Show/Hide sidebar buttons have inconsistent highlighted state

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Joseph Pecoraro 2015-05-15 14:10:31 PDT

* SUMMARY
Show/Hide sidebar buttons have inconsistent highlighted state.

* STEPS TO REPRODUCE
1. Inspect <http://webkit.org>
2. Open Elements and Resources tabs
3. Show the Details Sidebar in each
4. Select the Resources tab
5. Close the Inspector
6. Open Inspector => should be showing Resources Tab, with Details Sidebar, and Blue Highlighted Show/Hide sidebar button
7. Switch to Elements Tab
  => Details sidebar is showing, but Show/Hide sidebar button is not highlighted. Expected it to be.

Comment 1 Radar WebKit Bug Importer 2015-05-15 14:11:00 PDT

<rdar://problem/20980798>

Comment 2 Diego Pino 2015-06-17 11:56:23 PDT

Created attachment 255027 [details]
Patch

Comment 3 Joseph Pecoraro 2015-06-17 13:05:39 PDT

Comment on attachment 255027 [details]
Patch

Awesome! r=me

Comment 4 WebKit Commit Bot 2015-06-17 14:34:14 PDT

Comment on attachment 255027 [details]
Patch

Clearing flags on attachment: 255027

Committed r185669: <http://trac.webkit.org/changeset/185669>

Comment 5 WebKit Commit Bot 2015-06-17 14:34:18 PDT

All reviewed patches have been landed.  Closing bug.