Bug 14506 – CSS rendering problem when adding DOM objects with javascript

• Component: Layout and Rendering
• Status: RESOLVED DUPLICATE

[François Lamboley]

When I create an element (using DOM functions) with javascript, the rendering is not well done: the class names are not checked. Even the element name is not seen: the only thing that's done is adding the text node in the p element generated.

[François Lamboley]

Created attachment 15360 [details]
Test case

[Rob Buis]

Created attachment 15388 [details]
First attempt

This fixes the testcase and some existing tests. Unfortunately it is hard to see if it changes pixel tests rather than layout tests, since so many seem to fail anyway :}
Cheers,

Rob.

[Maciej Stachowiak]

I'm not sure this should be limited to a subset of xhtml doctypes. xhtml is never in quirks mode, so it would be better not to have quirks. I think it might make sense to just always do this for createElement().

[Darin Adler]

Comment on attachment 15388 [details]
First attempt

Setting review- based on Maciej's comments. I don't think we want to create a strict vs. quirks mode for XML unless there's some other browser or at least some specification suggesting we should do so.

It's probably right to have createElement always create XHTML elements in any XML document, especially if that's consistent with what other browsers do.

Looking at Document::setTitle, it seems that function already assumes it will do so!

See also bug 8007.

[Alexey Proskuryakov]

..and bug 10932, which also contains a lot of discussion.

[Rob Buis]

Created attachment 15445 [details]
New approach

This patch follows comment #18 in bug 10932, i.e. Opera's solution. dom/xhtml/level3/core/nodelookupprefix10 is a bit special, it fails in Opera, FF2 and with this
patch, so maybe that test is broken?
Cheers,

Rob.

[Alexey Proskuryakov]

HTML 5 currently says:

---------------
Document.createElement()
The canonical form of HTML markup is all-lowercase; thus, this method will lowercase the argument before creating the requisite element. Also, the element created must be in the HTML namespace.
---------------

This follows a long discussion from Mozilla bugs, e.g. <https://bugzilla.mozilla.org/show_bug.cgi?id=354318#c2>.

Also, does the new test need to be a pixel one?

[Maciej Stachowiak]

Comment on attachment 15445 [details]
New approach

Given what HTML5 says, and Mozilla's stance, I think we should just make createElement always use the xhtml namespace. It would then be possible to remove the HTMLDocument override for createElement.

[Maciej Stachowiak]

http://bugs.webkit.org/show_bug.cgi?id=8007 is a duplicate and my proposed solution would render http://bugs.webkit.org/show_bug.cgi?id=10932 a wontfix.

[Darin Adler]

*** This bug has been marked as a duplicate of 8007 ***