Bug 145018 – [CMake] Don't read the LOCATION property of targets

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Michael Catanzaro]

To silence the nasty warning we get when running cmake.

$ cmake --help-policy CMP0026
CMP0026
-------

Disallow use of the LOCATION target property.

CMake 2.8.12 and lower allowed reading the LOCATION target
property (and configuration-specific variants) to
determine the eventual location of build targets.  This relies on the
assumption that all necessary information is available at
configure-time to determine the final location and filename of the
target.  However, this property is not fully determined until later at
generate-time.  At generate time, the $<TARGET_FILE> generator
expression can be used to determine the eventual LOCATION of a target
output.

Code which reads the LOCATION target property can be ported to use the
$<TARGET_FILE> generator expression together with the file(GENERATE)
subcommand to generate a file containing the target location.

The OLD behavior for this policy is to allow reading the LOCATION
properties from build-targets.  The NEW behavior for this policy is to
not to allow reading the LOCATION properties from build-targets.

This policy was introduced in CMake version 3.0.  CMake version
3.2.2 warns when the policy is not set and uses OLD behavior.  Use
the cmake_policy command to set it to OLD or NEW explicitly.

[Michael Catanzaro]

Created attachment 253142 [details]
Patch

[Martin Robinson]

Comment on attachment 253142 [details]
Patch

Cleaner too. Nice.

[WebKit Commit Bot]

Comment on attachment 253142 [details]
Patch

Clearing flags on attachment: 253142

Committed r184357: <http://trac.webkit.org/changeset/184357>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.