Bug 145014

Summary:

[CMake] Error out when ruby is too old

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

Tools / Tests

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, commit-queue, fpizlo, mcatanzaro, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

See Also:

https://bugzilla.redhat.com/show_bug.cgi?id=1221810

Attachments:

Description	Flags
Patch	none

Description Michael Catanzaro 2015-05-14 12:09:25 PDT

The build should error out when running cmake if ruby is too old, not progress all the way to trying to build LLint files.

Comment 1 Michael Catanzaro 2015-05-14 14:19:20 PDT

Any ideas why this isn't currently marked as REQUIRED? It looks like it might have been omitted intentionally, but it's definitely mandatory to build JSC.

Comment 2 Michael Catanzaro 2015-05-14 14:20:30 PDT

Answer:

# We cannot check for RUBY_FOUND because it is set only when the full package is installed and
# the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro
# for finding the only Ruby interpreter.
if (NOT RUBY_EXECUTABLE)
    message(FATAL_ERROR "The Ruby interpreter is needed to generate LLInt files.")
endif ()

Comment 3 Michael Catanzaro 2015-05-14 14:37:27 PDT

Created attachment 253146 [details]
Patch

Comment 4 WebKit Commit Bot 2015-05-14 17:10:21 PDT

Comment on attachment 253146 [details]
Patch

Clearing flags on attachment: 253146

Committed r184363: <http://trac.webkit.org/changeset/184363>

Comment 5 WebKit Commit Bot 2015-05-14 17:10:25 PDT

All reviewed patches have been landed.  Closing bug.