Bug 145014

Summary: [CMake] Error out when ruby is too old
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, fpizlo, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1221810
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-05-14 12:09:25 PDT
The build should error out when running cmake if ruby is too old, not progress all the way to trying to build LLint files.
Attachments
Patch (2.98 KB, patch)
2015-05-14 14:37 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-05-14 14:19:20 PDT
Any ideas why this isn't currently marked as REQUIRED? It looks like it might have been omitted intentionally, but it's definitely mandatory to build JSC.
Michael Catanzaro
Comment 2 2015-05-14 14:20:30 PDT
Answer: # We cannot check for RUBY_FOUND because it is set only when the full package is installed and # the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro # for finding the only Ruby interpreter. if (NOT RUBY_EXECUTABLE) message(FATAL_ERROR "The Ruby interpreter is needed to generate LLInt files.") endif ()
Michael Catanzaro
Comment 3 2015-05-14 14:37:27 PDT
Created attachment 253146 [details] Patch
WebKit Commit Bot
Comment 4 2015-05-14 17:10:21 PDT
Comment on attachment 253146 [details] Patch Clearing flags on attachment: 253146 Committed r184363: <http://trac.webkit.org/changeset/184363>
WebKit Commit Bot
Comment 5 2015-05-14 17:10:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.