Bug 144995

Summary: [GTK] Enable plugin-related CMake options and variables for the X11 target only
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2015-05-14 01:39:41 PDT
[GTK] Enable plugin-related CMake options for the X11 target only
Attachments
Patch (2.83 KB, patch)
2015-05-14 01:43 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.84 KB, patch)
2015-05-14 02:26 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-05-14 01:43:27 PDT
Created attachment 253113 [details] Patch
Carlos Garcia Campos
Comment 2 2015-05-14 02:15:59 PDT
Comment on attachment 253113 [details] Patch I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it doesn't really work, so let's use this for now.
Zan Dobersek
Comment 3 2015-05-14 02:20:42 PDT
(In reply to comment #2) > Comment on attachment 253113 [details] > Patch > > I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it > doesn't really work, so let's use this for now. It turns out it does work, though it doesn't affect values in CMakeCache.txt but only those in cmakeconfig.h. Plus, it only works for configurable options (like ENABLE_NETSCAPE_PLUGIN_API and ENABLE_PLUGIN_PROCESS_GTK2) and not for ordinary variables like ENABLE_PLUGIN_PROCESS.
Zan Dobersek
Comment 4 2015-05-14 02:26:59 PDT
Created attachment 253116 [details] Patch for landing
Zan Dobersek
Comment 5 2015-05-14 03:53:47 PDT
Comment on attachment 253116 [details] Patch for landing Clearing flags on attachment: 253116 Committed r184335: <http://trac.webkit.org/changeset/184335>
Zan Dobersek
Comment 6 2015-05-14 03:53:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.