Bug 144995

Summary:

[GTK] Enable plugin-related CMake options and variables for the X11 target only

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Zan Dobersek 2015-05-14 01:39:41 PDT

[GTK] Enable plugin-related CMake options for the X11 target only

Comment 1 Zan Dobersek 2015-05-14 01:43:27 PDT

Created attachment 253113 [details]
Patch

Comment 2 Carlos Garcia Campos 2015-05-14 02:15:59 PDT

Comment on attachment 253113 [details]
Patch

I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it doesn't really work, so let's use this for now.

Comment 3 Zan Dobersek 2015-05-14 02:20:42 PDT

(In reply to comment #2)
> Comment on attachment 253113 [details]
> Patch
> 
> I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it
> doesn't really work, so let's use this for now.

It turns out it does work, though it doesn't affect values in CMakeCache.txt but only those in cmakeconfig.h.

Plus, it only works for configurable options (like ENABLE_NETSCAPE_PLUGIN_API and ENABLE_PLUGIN_PROCESS_GTK2) and not for ordinary variables like ENABLE_PLUGIN_PROCESS.

Comment 4 Zan Dobersek 2015-05-14 02:26:59 PDT

Created attachment 253116 [details]
Patch for landing

Comment 5 Zan Dobersek 2015-05-14 03:53:47 PDT

Comment on attachment 253116 [details]
Patch for landing

Clearing flags on attachment: 253116

Committed r184335: <http://trac.webkit.org/changeset/184335>

Comment 6 Zan Dobersek 2015-05-14 03:53:53 PDT

All reviewed patches have been landed.  Closing bug.