Bug 144986 – White edge on animating panel on http://rokkosunnyvale.com

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

1. Load rokkosunnyvale.com
2. Wait for the animation
Notice the white edge on the panel while animating.

[alan]

rdar://problem/20907683

[alan]

Created attachment 253094 [details]
Patch

[Build Bot]

Comment on attachment 253094 [details]
Patch

Attachment 253094 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4832866173190144

New failing tests:
fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html

[Build Bot]

Created attachment 253096 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[alan]

Created attachment 253097 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 253097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253097&action=review

> Source/WebCore/rendering/RenderBox.cpp:1349
> +bool RenderBox::getBackgroundPaintedExtent(const LayoutPoint& absolutePaintPosition, LayoutRect& paintedExtent) const

I think "absolute" is misleading here; it's not absolute when painting in graphics layers. Maybe just paintOffset?

> Source/WebCore/rendering/RenderBox.cpp:1469
> +bool RenderBox::computeBackgroundIsKnownToBeObscured(const LayoutPoint& absolutePaintPosition)

Ditto.

> Source/WebCore/rendering/RenderBox.cpp:1562
> +LayoutRect RenderBox::maskClipRect(const LayoutPoint& absolutePaintPosition)

Ditto.

> Source/WebCore/rendering/RenderBox.h:517
> +    LayoutRect maskClipRect(const LayoutPoint& absolutePaintPosition);

paintOffset

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1073
> +    const LayoutRect& relativePaintRect, RenderElement* backgroundObject) const

relativePaintRect is relative to the renderer? Or does it include the current paint offset?

[Simon Fraser (smfr)]

Comment on attachment 253097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253097&action=review

> Source/WebCore/rendering/RenderBox.cpp:1704
> +            BackgroundImageGeometry geometry = layerRenderer->calculateBackgroundImageGeometry(nullptr, *curLayer, LayoutPoint(), rendererRect);

I think this needs a FIXME comment.

>> Source/WebCore/rendering/RenderBoxModelObject.cpp:1073
>> +    const LayoutRect& relativePaintRect, RenderElement* backgroundObject) const
> 
> relativePaintRect is relative to the renderer? Or does it include the current paint offset?

Maybe borderBoxRect?

[alan]

Created attachment 253200 [details]
Patch

[alan]

(In reply to comment #6)
> Comment on attachment 253097 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253097&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:1349
> > +bool RenderBox::getBackgroundPaintedExtent(const LayoutPoint& absolutePaintPosition, LayoutRect& paintedExtent) const
> 
> I think "absolute" is misleading here; it's not absolute when painting in
> graphics layers. Maybe just paintOffset?
> 
> > Source/WebCore/rendering/RenderBox.cpp:1469
> > +bool RenderBox::computeBackgroundIsKnownToBeObscured(const LayoutPoint& absolutePaintPosition)
> 
> Ditto.
> 
> > Source/WebCore/rendering/RenderBox.cpp:1562
> > +LayoutRect RenderBox::maskClipRect(const LayoutPoint& absolutePaintPosition)
> 
> Ditto.
> 
> > Source/WebCore/rendering/RenderBox.h:517
> > +    LayoutRect maskClipRect(const LayoutPoint& absolutePaintPosition);
> 
> paintOffset
> 
Done.

> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1073
> > +    const LayoutRect& relativePaintRect, RenderElement* backgroundObject) const
> 
> relativePaintRect is relative to the renderer? Or does it include the
> current paint offset?
No, it does not include the paint offset.

> Source/WebCore/rendering/RenderBox.cpp:1704
> +            BackgroundImageGeometry geometry = layerRenderer->calculateBackgroundImageGeometry(nullptr, *curLayer, LayoutPoint(), rendererRect);

>I think this needs a FIXME comment.
Done.

>> Source/WebCore/rendering/RenderBoxModelObject.cpp:1073
>> +    const LayoutRect& relativePaintRect, RenderElement* backgroundObject) const
> 
> relativePaintRect is relative to the renderer? Or does it include the current paint offset?
>Maybe borderBoxRect?
Done.

[WebKit Commit Bot]

Comment on attachment 253200 [details]
Patch

Rejecting attachment 253200 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 253200, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5898968324112384

[alan]

Created attachment 253204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 253204 [details]
Patch

Clearing flags on attachment: 253204

Committed r184395: <http://trac.webkit.org/changeset/184395>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.