| Summary: | REGRESSION(r183770): Crash inside WebEditorClient::shouldApplyStyle when applying underline | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, enrica | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 253026 [details]
Fixes the crash
Comment on attachment 253026 [details] Fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=253026&action=review Thanks for the review! > LayoutTests/ChangeLog:12 > + * editing/style/underline-by-user.html: Added. Oops, I forgot to add -expected.txt in svn. Will do that before landing it. Committed r184308: <http://trac.webkit.org/changeset/184308> |
> 1 com.apple.WebKitLegacy 0x7fff8b329185 WebEditorClient::shouldApplyStyle(WebCore::StyleProperties*, WebCore::Range*) + 0x15 2 com.apple.WebCore 0x7fff87e6864c WebCore::Editor::applyStyleToSelection(WTF::Ref<WebCore::EditingStyle>&&, WebCore::EditAction) + 0x9c 3 com.apple.WebCore 0x7fff87e77c4c WebCore::applyCommandToFrame(WebCore::Frame&, WebCore::EditorCommandSource, WebCore::EditAction, WTF::Ref<WebCore::EditingStyle>&&) + 0x5c 4 com.apple.WebCore 0x7fff87e77698 WebCore::executeUnderline(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 0x68 5 com.apple.WebCore 0x7fff87ba7d86 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const + 0xb6 6 com.apple.WebKitLegacy 0x7fff8b2cd819 -[WebHTMLView executeCoreCommandBySelector:] + 0x69