Bug 144925

Summary: Refactor MachineStackMarker.cpp so that it's easier to reason about MachineThreads::Thread.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, mmirman, msaboff
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144924    
Attachments:
Description Flags
the patch.
mark.lam: review-
patch 2
none
patch 3: with build fixes
none
patch 4: build fix 2 msaboff: review+

Mark Lam
Reported 2015-05-12 12:49:24 PDT
Currently, the code in MachineStackMarker.cpp is written as a bunch of functions that operate on the platformThread value in the MachineThreads::Thread struct. Instead, we can apply better OO encapsulation and convert all these functions into methods of the MachineThreads::Thread struct. This will also make it easier to reason about the fix for https://bugs.webkit.org/show_bug.cgi?id=144924 later.
Attachments
the patch. (11.75 KB, patch)
2015-05-12 13:03 PDT, Mark Lam 		mark.lam: review-
DetailsFormatted DiffDiff
patch 2 (11.80 KB, patch)
2015-05-12 13:38 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch 3: with build fixes (12.84 KB, patch)
2015-05-12 13:44 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch 4: build fix 2 (11.95 KB, patch)
2015-05-12 13:51 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-05-12 12:52:29 PDT
<rdar://problem/18736465>
Mark Lam
Comment 2 2015-05-12 13:03:03 PDT
Created attachment 252977 [details] the patch.
Mark Lam
Comment 3 2015-05-12 13:08:54 PDT
Comment on attachment 252977 [details] the patch. I think I can improve the readability a little more. Will upload a 2nd patch shortly.
Mark Lam
Comment 4 2015-05-12 13:38:00 PDT
Created attachment 252979 [details] patch 2
Mark Lam
Comment 5 2015-05-12 13:44:39 PDT
Created attachment 252980 [details] patch 3: with build fixes
Mark Lam
Comment 6 2015-05-12 13:51:22 PDT
Created attachment 252982 [details] patch 4: build fix 2
Michael Saboff
Comment 7 2015-05-12 14:02:29 PDT
Comment on attachment 252982 [details] patch 4: build fix 2 r=me Make sure Windows EWS builds
Mark Lam
Comment 8 2015-05-12 14:23:00 PDT
The EWS bots are happy. Landed in r184218: <http://trac.webkit.org/r184218>.
Note You need to log in before you can comment on or make changes to this bug.