Bug 144922

Summary:

Production builds should link against the shims directly

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2015-05-12 12:19:19 PDT

Production builds should link against the shims directly

Comment 1 Anders Carlsson 2015-05-12 12:23:47 PDT

Created attachment 252976 [details]
Patch

Comment 2 mitz 2015-05-12 12:46:49 PDT

Comment on attachment 252976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252976&action=review

> Source/WebKit2/Configurations/PluginService.64.xcconfig:33
>  INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;

This should be using the legacy plist on 10.9 and 10.10.

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:2423
> +		1A6D14211B01681600785FF0 /* PluginService.32-64-10.9-10.10.Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = "PluginService.32-64-10.9-10.10.Info.plist"; path = "PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist"; sourceTree = SOURCE_ROOT; };

Can this be group-relative?

Comment 3 Anders Carlsson 2015-05-12 13:47:58 PDT

Committed r184215: <http://trac.webkit.org/changeset/184215>