Bug 144920

Summary:

Don't compute selection painting info when we don't have selection

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dave Hyatt 2015-05-12 11:54:56 PDT

Don't waste time computing selection painting info when we don't even have a selection.

Comment 1 Dave Hyatt 2015-05-12 11:57:01 PDT

Created attachment 252974 [details]
Patch

Comment 2 Simon Fraser (smfr) 2015-05-12 11:59:49 PDT

Comment on attachment 252974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252974&action=review

> Source/WebCore/ChangeLog:5
> +

And rdar://problem/20919920

> Source/WebCore/ChangeLog:12
> +        at all. computing the selection style takes time in the case where a ::selection pseudo is

computing -> Computing

Comment 3 Dave Hyatt 2015-05-13 11:57:56 PDT

Fixed in r184293.