Bug 144920

Summary: Don't compute selection painting info when we don't have selection
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dave Hyatt
Reported 2015-05-12 11:54:56 PDT
Don't waste time computing selection painting info when we don't even have a selection.
Attachments
Patch (2.34 KB, patch)
2015-05-12 11:57 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-05-12 11:57:01 PDT
Created attachment 252974 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-05-12 11:59:49 PDT
Comment on attachment 252974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252974&action=review > Source/WebCore/ChangeLog:5 > + And rdar://problem/20919920 > Source/WebCore/ChangeLog:12 > + at all. computing the selection style takes time in the case where a ::selection pseudo is computing -> Computing
Dave Hyatt
Comment 3 2015-05-13 11:57:56 PDT
Fixed in r184293.
Note You need to log in before you can comment on or make changes to this bug.