Summary: | [Streams API] Delegate ReadableStreamReader reference counting to ReadableStream | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, calvaris, commit-queue, darin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2015-05-12 02:35:36 PDT
Created attachment 252953 [details]
WIP
(In reply to comment #1) > Created attachment 252953 [details] > WIP WIP, does not contain moving closedpromise callback handling to ReadableStream, which would be the next logical step. Created attachment 252958 [details]
Patch
Created attachment 252973 [details]
Patch
Comment on attachment 252973 [details]
Patch
This patch improves style over the previous patch.
It shows the benefit of removing RefCounted from ReadableStreamReader.
This removes code and at the end, there should be no need for a ReadableStreamReader.cpp, just like ReadableStreamController.
There are two downsides though:
- The ReadableStream will not be released until all readers, including released readers, are collected by the JS engine.
- The ReadableStream currently needs to keep track of all released readers.
Overall I think that this is an improvement, so r?
Comment on attachment 252973 [details] Patch Clearing flags on attachment: 252973 Committed r184444: <http://trac.webkit.org/changeset/184444> All reviewed patches have been landed. Closing bug. |