| Summary: | Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 144946 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 252985 [details]
[Patch] Proposed Fix
Comment on attachment 252985 [details]
[Patch] Proposed Fix
r=me
Comment on attachment 252985 [details] [Patch] Proposed Fix Clearing flags on attachment: 252985 Committed r184224: <http://trac.webkit.org/changeset/184224> All reviewed patches have been landed. Closing bug. This made inspector/page/main-frame-resource.hmtl assert every time: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r184224%20(4610)/inspector/page/main-frame-resource-crash-log.txt Rolling out. Re-opened since this is blocked by bug 144946 Created attachment 253061 [details]
[Patch] Proposed Fix
Comment on attachment 253061 [details]
[Patch] Proposed Fix
r=me
Comment on attachment 253061 [details] [Patch] Proposed Fix Clearing flags on attachment: 253061 Committed r184428: <http://trac.webkit.org/changeset/184428> All reviewed patches have been landed. Closing bug. |
* SUMMARY Timeline recording started from console.profile is always empty. The recording starts and stops (this is noticeable when profiling long-running code), but not timeline records are added. * STEPS TO REPRODUCE 1. Open the Inspector, go to Timelines 2. Start profiling from the console: console.profile("My profile") 3. Execute some JavaScript 4. Stop profiling: console.profileEnd("My profile") => console.profile causes a new recording to start, but no records are added