Bug 144862

Summary:

Add srcset, sizes and picture to the features json

Product:

WebKit

Reporter:

Yoav Weiss <yoav>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Yoav Weiss 2015-05-11 02:30:03 PDT

Add srcset, sizes and picture to the features json

Comment 1 Yoav Weiss 2015-05-11 02:32:05 PDT

Created attachment 252852 [details]
Patch

Comment 2 Timothy Hatcher 2015-05-11 09:43:06 PDT

Comment on attachment 252852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252852&action=review

> Source/WebCore/features.json:289
> +        "name": "Srcset w descriptor and related sizes attribute",

If we are mentioning "w descriptors", we should mention "x descriptors" as well. Just mentioning one will lead visitors to believe we don't support the other.

Comment 3 Yoav Weiss 2015-05-11 09:44:22 PDT

Good call. I'll add a section about x descriptors as well.

Comment 4 Yoav Weiss 2015-05-11 09:51:09 PDT

Created attachment 252862 [details]
Patch

Comment 5 WebKit Commit Bot 2015-05-11 12:34:26 PDT

Comment on attachment 252862 [details]
Patch

Clearing flags on attachment: 252862

Committed r184115: <http://trac.webkit.org/changeset/184115>

Comment 6 WebKit Commit Bot 2015-05-11 12:34:30 PDT

All reviewed patches have been landed.  Closing bug.