Bug 144853

Summary: js/dom/stack-trace.html fails with eager compilation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 144877    
Bug Blocks: 144945    
Attachments:
Description Flags
starting to work
none
the patch benjamin: review+

Filip Pizlo
Reported 2015-05-10 21:09:07 PDT
Patch forthcoming.
Attachments
starting to work (40.06 KB, patch)
2015-05-12 20:36 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (49.98 KB, patch)
2015-05-12 21:36 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-05-12 18:06:28 PDT
This looks like an FTL bug. No FTL and the bug goes away.
Filip Pizlo
Comment 2 2015-05-12 18:20:10 PDT
Wow, this is hilarious. The various escape analyses don't have any clue how to handle: a: NewObject() b: Check(Number:@a) or anything else like that where the check is guaranteed to fail.
Filip Pizlo
Comment 3 2015-05-12 20:36:33 PDT
Created attachment 253012 [details] starting to work
Filip Pizlo
Comment 4 2015-05-12 21:36:58 PDT
Created attachment 253018 [details] the patch One of the newly introduced tests is still crashing. I'll investigate whether this is related to my patch or not. If it's unrelated then I'll land the test skipped and file a separate bug.
WebKit Commit Bot
Comment 5 2015-05-12 21:39:22 PDT
Attachment 253018 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp:171: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGVarargsForwardingPhase.cpp:111: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2015-05-12 21:58:09 PDT
(In reply to comment #4) > Created attachment 253018 [details] > the patch > > One of the newly introduced tests is still crashing. I'll investigate > whether this is related to my patch or not. If it's unrelated then I'll > land the test skipped and file a separate bug. Yup, it's a preexisting separate bug: https://bugs.webkit.org/show_bug.cgi?id=144945
Benjamin Poulain
Comment 7 2015-05-12 22:03:08 PDT
Comment on attachment 253018 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=253018&action=review > Source/JavaScriptCore/jsc.cpp:624 > + putDirectNativeFunction(vm, this, Identifier::fromString(&vm, "isInt32"), 0, functionIsInt32, CheckInt32, DontEnum | JSC::Function); I would prefer CheckInt32Intrinsic to follow the other intrinsics naming.
Filip Pizlo
Comment 8 2015-05-12 22:23:04 PDT
Landed in http://trac.webkit.org/changeset/184260
Note You need to log in before you can comment on or make changes to this bug.