Bug 144850

Summary:

run-benchmark should support Chrome Canary and Firefox Nightly

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, dewei_zhu, glenn, kling, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144842

Attachments:

Description	Flags
Adds the support	none

Description Ryosuke Niwa 2015-05-10 16:07:13 PDT

Add the support for these two browsers.

Comment 1 Ryosuke Niwa 2015-05-10 16:11:37 PDT

Created attachment 252829 [details]
Adds the support

Comment 2 WebKit Commit Bot 2015-05-10 16:14:41 PDT

Attachment 252829 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:6:  No name 'NSRunningApplication' in module 'AppKit'  [pylint/E0611] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2015-05-11 11:04:23 PDT

Comment on attachment 252829 [details]
Adds the support

Clearing flags on attachment: 252829

Committed r184109: <http://trac.webkit.org/changeset/184109>

Comment 4 WebKit Commit Bot 2015-05-11 11:04:27 PDT

All reviewed patches have been landed.  Closing bug.