Bug 144840

Summary:

run-benchmark should support SunSpider, Kraken and Octane

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, dewei_zhu, glenn, kling, msaboff, ossy, slewis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144842, 144849

Attachments:

Description	Flags
Adds the support	none
Adds the support	none
Fixed a bug	none
Fixed kraken.plan	none

Ryosuke Niwa

Reported 2015-05-09 20:49:13 PDT

We should be able to run SunSpider and Kraken using run-benchmark.

Attachments
Adds the support (17.08 KB, patch) 2015-05-09 21:05 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Adds the support (30.63 KB, patch) 2015-05-10 01:25 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed a bug (30.38 KB, patch) 2015-05-10 03:22 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed kraken.plan (30.38 KB, patch) 2015-05-10 03:26 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2015-05-09 21:05:22 PDT

Created attachment 252804 [details] Adds the support

Ryosuke Niwa

Comment 2 2015-05-10 00:51:57 PDT

Comment on attachment 252804 [details] Adds the support Let me change the strategy a little...

Ryosuke Niwa

Comment 3 2015-05-10 01:25:18 PDT

Created attachment 252807 [details] Adds the support

Ryosuke Niwa

Comment 4 2015-05-10 03:22:18 PDT

Created attachment 252810 [details] Fixed a bug

Ryosuke Niwa

Comment 5 2015-05-10 03:26:30 PDT

Created attachment 252811 [details] Fixed kraken.plan

Ryosuke Niwa

Comment 6 2015-05-11 14:42:06 PDT

Thanks for the reviews, Darin!

Ryosuke Niwa

Comment 7 2015-05-11 14:42:14 PDT

Comment on attachment 252811 [details] Fixed kraken.plan Clearing flags on attachment: 252811 Committed r184124: <http://trac.webkit.org/changeset/184124>

Ryosuke Niwa

Comment 8 2015-05-11 14:42:19 PDT

All reviewed patches have been landed. Closing bug.

dewei_zhu

Comment 9 2015-05-11 15:19:39 PDT

Comment on attachment 252811 [details] Fixed kraken.plan View in context: https://bugs.webkit.org/attachment.cgi?id=252811&action=review > Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:6 > + "remote_archive": "../../../../PerformanceTests/JetStream", Is this supposed to be local_copy? > Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:8 > + "create_script": ["ruby", "create.rb"], Since it only runs on the machine that is under control, it may not be a security issue.

Ryosuke Niwa

Comment 10 2015-05-11 15:35:57 PDT

Comment on attachment 252811 [details] Fixed kraken.plan View in context: https://bugs.webkit.org/attachment.cgi?id=252811&action=review >> Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:6 >> + "remote_archive": "../../../../PerformanceTests/JetStream", > > Is this supposed to be local_copy? Oops, right. Will fix that.

Ryosuke Niwa

Comment 11 2015-05-11 15:38:31 PDT

Fixed in http://trac.webkit.org/changeset/184126.

Note You need to log in before you can comment on or make changes to this bug.