Bug 144840

Summary:

run-benchmark should support SunSpider, Kraken and Octane

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, dewei_zhu, glenn, kling, msaboff, ossy, slewis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144842, 144849

Attachments:

Description	Flags
Adds the support	none
Adds the support	none
Fixed a bug	none
Fixed kraken.plan	none

Description Ryosuke Niwa 2015-05-09 20:49:13 PDT

We should be able to run SunSpider and Kraken using run-benchmark.

Comment 1 Ryosuke Niwa 2015-05-09 21:05:22 PDT

Created attachment 252804 [details]
Adds the support

Comment 2 Ryosuke Niwa 2015-05-10 00:51:57 PDT

Comment on attachment 252804 [details]
Adds the support

Let me change the strategy a little...

Comment 3 Ryosuke Niwa 2015-05-10 01:25:18 PDT

Created attachment 252807 [details]
Adds the support

Comment 4 Ryosuke Niwa 2015-05-10 03:22:18 PDT

Created attachment 252810 [details]
Fixed a bug

Comment 5 Ryosuke Niwa 2015-05-10 03:26:30 PDT

Created attachment 252811 [details]
Fixed kraken.plan

Comment 6 Ryosuke Niwa 2015-05-11 14:42:06 PDT

Thanks for the reviews, Darin!

Comment 7 Ryosuke Niwa 2015-05-11 14:42:14 PDT

Comment on attachment 252811 [details]
Fixed kraken.plan

Clearing flags on attachment: 252811

Committed r184124: <http://trac.webkit.org/changeset/184124>

Comment 8 Ryosuke Niwa 2015-05-11 14:42:19 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 dewei_zhu 2015-05-11 15:19:39 PDT

Comment on attachment 252811 [details]
Fixed kraken.plan

View in context: https://bugs.webkit.org/attachment.cgi?id=252811&action=review

> Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:6
> +    "remote_archive": "../../../../PerformanceTests/JetStream",

Is this supposed to be local_copy?

> Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:8
> +    "create_script": ["ruby", "create.rb"],

Since it only runs on the machine that is under control, it may not be a security issue.

Comment 10 Ryosuke Niwa 2015-05-11 15:35:57 PDT

Comment on attachment 252811 [details]
Fixed kraken.plan

View in context: https://bugs.webkit.org/attachment.cgi?id=252811&action=review

>> Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:6
>> +    "remote_archive": "../../../../PerformanceTests/JetStream",
> 
> Is this supposed to be local_copy?

Oops, right. Will fix that.

Comment 11 Ryosuke Niwa 2015-05-11 15:38:31 PDT

Fixed in http://trac.webkit.org/changeset/184126.