| Summary: | [iOS] MediaControls: disappear while scrubbing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jer.noble | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2015-05-07 18:03:54 PDT
Created attachment 252665 [details]
Patch
Committed r183971: <http://trac.webkit.org/changeset/183971> There were some changes in the commit which were not in the patch, namely changes to mediaControlsApple.js: adding a reference to _potentiallyScrubbing which does not exist in mediaControlsApple.js. We should fix this. --- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183953)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183971)
@@ -1363,5 +1363,5 @@
hideControls: function()
{
- if (this.controlsAlwaysVisible())
+ if (this.controlsAlwaysVisible() || this._potentiallyScrubbing)
We should revert this change, and modify controlsAlwaysVisible() in mediaControlsIOS.js to return true if this._potentiallyScrubbing is true.
Comment on attachment 252665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252665&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:525 > + this.resetHideControlsTimer(); I think this shows that this function might need a different name. The verb "reset" is perhaps too ambiguous. |