Bug 144758

Summary: Release assert in com.apple.WebKit.WebContent under JavaScriptCore: JSC::JSONProtoFuncStringify
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, ddkilzer, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch kling: review+

Description Geoffrey Garen 2015-05-07 14:16:08 PDT
Release assert in com.apple.WebKit.WebContent under JavaScriptCore: JSC::JSONProtoFuncStringify
Comment 1 Geoffrey Garen 2015-05-07 14:16:42 PDT
<rdar://problem/20486283>
Comment 2 Geoffrey Garen 2015-05-07 14:20:27 PDT
Created attachment 252625 [details]
Patch
Comment 3 Andreas Kling 2015-05-07 14:35:24 PDT
Comment on attachment 252625 [details]
Patch

r=me
Comment 4 Build Bot 2015-05-07 14:50:00 PDT
Comment on attachment 252625 [details]
Patch

Attachment 252625 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5179393798307840

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-05-07 14:50:02 PDT
Created attachment 252632 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Geoffrey Garen 2015-05-07 15:07:44 PDT
Comment on attachment 252625 [details]
Patch

Broken :(.
Comment 7 Geoffrey Garen 2015-05-07 15:18:01 PDT
Created attachment 252635 [details]
Patch
Comment 8 Geoffrey Garen 2015-05-07 15:24:39 PDT
Comment on attachment 252635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252635&action=review

> Source/bmalloc/bmalloc/StaticMutex.cpp:34
> -        std::this_thread::yield();
> +        { }

Oops! Will revert this part.
Comment 9 Andreas Kling 2015-05-07 16:21:28 PDT
Comment on attachment 252635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252635&action=review

Damn, too much itchy in the trigger finger last time. :|

>> Source/bmalloc/bmalloc/StaticMutex.cpp:34
>> +        { }
> 
> Oops! Will revert this part.

k
Comment 10 Geoffrey Garen 2015-05-07 16:30:34 PDT
Committed r183959: <http://trac.webkit.org/changeset/183959>