Bug 144716

Summary: [WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2015-05-06 15:12:34 PDT 
[WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.
Comment 1 Jer Noble 2015-05-06 15:19:05 PDT 
Created attachment 252525 [details]
Patch
Comment 2 Darin Adler 2015-05-06 16:52:48 PDT 
Comment on attachment 252525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303
> +        [contentView.layer removeAllAnimations];
> +        [[_clipView layer] removeAllAnimations];
> +        [[_clipView layer].mask removeAllAnimations];

Strange to mix x.layer and [x layer] here.
Comment 3 Jer Noble 2015-05-06 18:52:06 PDT 
Comment on attachment 252525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303
>> +        [[_clipView layer].mask removeAllAnimations];
> 
> Strange to mix x.layer and [x layer] here.

Id love it if we could use dot-notation with RetainPtr<>. We could also do foo,get().layer.
Comment 4 Jer Noble 2015-05-06 21:10:40 PDT 
<rdar://problem/20702435>
Comment 5 WebKit Commit Bot 2015-05-06 21:57:33 PDT 
Comment on attachment 252525 [details]
Patch

Clearing flags on attachment: 252525

Committed r183911: <http://trac.webkit.org/changeset/183911>
Comment 6 WebKit Commit Bot 2015-05-06 21:57:37 PDT 
All reviewed patches have been landed.  Closing bug.