Bug 144711

Summary:

Perf dashboard treats Speedometer and JetStream as smaller is better

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, kling, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	cdumez: review+

Description Ryosuke Niwa 2015-05-06 14:47:41 PDT

Fix that.

Comment 1 Ryosuke Niwa 2015-05-06 14:49:31 PDT

Created attachment 252520 [details]
Fixes the bug

Comment 2 Chris Dumez 2015-05-06 14:50:40 PDT

Comment on attachment 252520 [details]
Fixes the bug

r=me!

Comment 3 Ryosuke Niwa 2015-05-06 14:51:01 PDT

Comment on attachment 252520 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=252520&action=review

> Websites/perf.webkit.org/public/js/helper-classes.js:165
> -        'Allocations': 'B'}[suffix];
> +        'Allocations': 'B',
> +        'Score': 'pt'}[suffix];

smallerIsBetter function in v1 returns true if it's equal to 'B' or 'ms'.

Comment 4 Ryosuke Niwa 2015-05-06 14:51:29 PDT

Committed r183890: <http://trac.webkit.org/changeset/183890>