Bug 144708

Summary:

RenderLayer::currentTransform computes a pixel snapped rect it doesn't use

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dave Hyatt 2015-05-06 13:52:36 PDT

RenderLayer::currentTransform computes a pixel snapped rect it doesn't use. Make sure to only compute the pixel snapped rect for the rare cases where we actually need it.

Comment 1 Dave Hyatt 2015-05-06 13:55:52 PDT

Created attachment 252518 [details]
Patch

Comment 2 Simon Fraser (smfr) 2015-05-06 13:58:47 PDT

Comment on attachment 252518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252518&action=review

> Source/WebCore/rendering/RenderLayer.cpp:977
> +    // Note that pixelSnappedBorderRect is only computed inside the if statements, since
> +    // the common case is that neither of these if conditions is matched.

I don't think this comment is necessary.

Comment 3 Dave Hyatt 2015-05-06 14:01:40 PDT

Fixed in r183887.