Bug 144704

Summary: Optimize topLeftLocationOffset() addition in updateLayerPosition
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch dino: review+

Description Dave Hyatt 2015-05-06 12:28:27 PDT 
Add a special apply function that can update the point without copies and inline it for speed.
Comment 1 Dave Hyatt 2015-05-06 12:32:09 PDT 
Created attachment 252511 [details]
Patch
Comment 2 Dave Hyatt 2015-05-06 12:35:11 PDT 
Created attachment 252512 [details]
Patch
Comment 3 WebKit Commit Bot 2015-05-06 12:36:29 PDT 
Attachment 252512 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.h:557:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2015-05-06 12:38:41 PDT 
Created attachment 252513 [details]
Patch
Comment 5 Dean Jackson 2015-05-06 13:39:36 PDT 
Comment on attachment 252513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252513&action=review

> Source/WebCore/rendering/RenderBox.cpp:4866
> +    containerBlock->flipForWritingMode(rect); // FIXME: This is wrong if we are an absolutely positioned object

Nit: Missing period in comment.
Comment 6 Dave Hyatt 2015-05-06 13:42:23 PDT 
Fixed in r183885.