Bug 144689

Summary: [WK2] Simplify AsyncRequestImpl::ArgumentType parameters
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: WebKit2Assignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, gyuyoung.kim, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joonghun Park
Reported 2015-05-06 09:34:03 PDT
Remove duplicated typename and ::type from AsyncRequestImpl related function parameters.
Attachments
Patch (2.88 KB, patch)
2015-05-06 09:40 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2015-05-06 09:40:47 PDT
Created attachment 252482 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-06 09:44:02 PDT
Attachment 252482 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/AsyncRequest.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2015-05-06 18:24:34 PDT
Comment on attachment 252482 [details] Patch Clearing flags on attachment: 252482 Committed r183903: <http://trac.webkit.org/changeset/183903>
WebKit Commit Bot
Comment 4 2015-05-06 18:24:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.