Bug 144674

Summary:

Add srcset preloader tests

Product:

WebKit

Reporter:

Yoav Weiss <yoav>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Yoav Weiss

Reported 2015-05-06 00:03:30 PDT

Add srcset preloader tests

Attachments
Patch (6.17 KB, patch) 2015-05-06 00:07 PDT, Yoav Weiss	no flags	Details Formatted Diff Diff
Patch (6.18 KB, patch) 2015-05-06 00:11 PDT, Yoav Weiss	no flags	Details Formatted Diff Diff
Patch (6.27 KB, patch) 2015-05-06 22:23 PDT, Yoav Weiss	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yoav Weiss

Comment 1 2015-05-06 00:07:27 PDT

Created attachment 252456 [details] Patch

WebKit Commit Bot

Comment 2 2015-05-06 00:09:47 PDT

Attachment 252456 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yoav Weiss

Comment 3 2015-05-06 00:11:59 PDT

Created attachment 252457 [details] Patch

Yoav Weiss

Comment 4 2015-05-06 00:16:31 PDT

Added a bunch of tests for the preloader and srcset, since when looking around that code, found that this part wasn't really tested.

Darin Adler

Comment 5 2015-05-06 09:20:58 PDT

Comment on attachment 252457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252457&action=review > LayoutTests/http/tests/loading/preload-img-src-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-src.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. > LayoutTests/http/tests/loading/preload-img-srcset-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-srcset-sizes-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-srcset-sizes.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. > LayoutTests/http/tests/loading/preload-img-srcset.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

Yoav Weiss

Comment 6 2015-05-06 22:23:57 PDT

Created attachment 252569 [details] Patch

WebKit Commit Bot

Comment 7 2015-05-06 23:14:28 PDT

Comment on attachment 252569 [details] Patch Clearing flags on attachment: 252569 Committed r183914: <http://trac.webkit.org/changeset/183914>

WebKit Commit Bot

Comment 8 2015-05-06 23:14:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.