| Summary: | Add srcset preloader tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dino | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yoav Weiss
2015-05-06 00:03:30 PDT
Created attachment 252456 [details]
Patch
Attachment 252456 [details] did not pass style-queue:
ERROR: LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 252457 [details]
Patch
Added a bunch of tests for the preloader and srcset, since when looking around that code, found that this part wasn't really tested. Comment on attachment 252457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252457&action=review > LayoutTests/http/tests/loading/preload-img-src-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-src.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. > LayoutTests/http/tests/loading/preload-img-srcset-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-srcset-sizes-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-img-srcset-sizes.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. > LayoutTests/http/tests/loading/preload-img-srcset.html:9 > +This test needs to be run in DRT. Preload scanner should see the image resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. Created attachment 252569 [details]
Patch
Comment on attachment 252569 [details] Patch Clearing flags on attachment: 252569 Committed r183914: <http://trac.webkit.org/changeset/183914> All reviewed patches have been landed. Closing bug. |