Bug 144665

Summary: Sane chain and string watchpoints should be set in FixupPhase or the backend rather than WatchpointCollectionPhase
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 144669, 144664    
Attachments:
Description Flags
the patch
none
the patch msaboff: review+

Filip Pizlo
Reported 2015-05-05 22:41:58 PDT
Patch forthcoming.
Attachments
the patch (8.84 KB, patch)
2015-05-05 23:14 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (8.99 KB, patch)
2015-05-05 23:27 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-05-05 23:14:54 PDT
Created attachment 252451 [details] the patch
Filip Pizlo
Comment 2 2015-05-05 23:27:54 PDT
Created attachment 252452 [details] the patch
Michael Saboff
Comment 3 2015-05-06 15:38:29 PDT
Comment on attachment 252452 [details] the patch r=me
Filip Pizlo
Comment 4 2015-05-06 16:16:00 PDT
Landed in http://trac.webkit.org/changeset/183897
Note You need to log in before you can comment on or make changes to this bug.