Bug 144633

Summary:

Only autoplay videos should not automatically play to playback target

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Updated patch	none

Description Eric Carlson 2015-05-05 12:28:01 PDT

Refine the selection criteria added in r183613 to allow any video that starts playing from a user gesture to play to target.

Comment 1 Radar WebKit Bug Importer 2015-05-05 12:28:59 PDT

<rdar://problem/20822993>

Comment 2 Eric Carlson 2015-05-05 12:36:51 PDT

Created attachment 252397 [details]
Proposed patch

Comment 3 Eric Carlson 2015-05-05 13:30:21 PDT

Created attachment 252400 [details]
Updated patch

Comment 4 WebKit Commit Bot 2015-05-05 13:32:35 PDT

Attachment 252400 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Eric Carlson 2015-05-05 13:53:03 PDT

Committed r183826: https://trac.webkit.org/r183826