Bug 144630

Summary: Some assertion failures in compositing code after r183820
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, esprehn+autocc, glenn, kondapallykalyan, krit, roger_fong, rosca, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Roger Fong 2015-05-05 10:06:35 PDT 
All that was changed was removal of a z-index: 0 from the media control styles.
This caused 5 tests to start generating assertion failures deep in compositing code, which implies an error with that code somehow.
After a bit of debugging I've decided that I have no idea where to even begin with compositing stuff.

The tests failing are:

compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/video-in-overflow-region.html
fast/regions/fullscreen/full-screen-video-from-region.html
fast/regions/fullscreen/full-screen-video-in-region-crash.html
fast/regions/inline-block-inside-anonymous-overflow.html

Though they pass in release.
In addition I have not hit the assertion just browsing around various videos using our controls in debug.
I will skip these tests for now.
Comment 1 Radar WebKit Bug Importer 2015-05-05 10:07:18 PDT 
<rdar://problem/20819825>
Comment 2 Roger Fong 2015-05-05 11:08:53 PDT 
Simon is taking a look at these.
Thanks Simon!
Comment 3 Simon Fraser (smfr) 2015-05-05 13:12:05 PDT 
    ASSERT(!layer.hasNotIsolatedCompositedBlendingDescendants() || layer.hasNotIsolatedBlendingDescendants());
Comment 4 Simon Fraser (smfr) 2015-05-05 14:06:35 PDT 
Seems related to isolates blending, and regions.
Comment 5 Roger Fong 2015-05-05 16:50:08 PDT 
Commented out assertion and unskipped tests here: http://trac.webkit.org/changeset/183843
Keeping bug open to keep track of the assertion being commented out.
Comment 6 Simon Fraser (smfr) 2015-05-28 15:50:55 PDT 
Created attachment 253871 [details]
Patch
Comment 7 Alexey Proskuryakov 2015-05-28 15:53:10 PDT 
Comment on attachment 253871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253871&action=review

rs=me

> Source/WebCore/ChangeLog:9
> +        escape the media elements, which was fixed in r145420.

This is probably bug 145420, not r145420.
Comment 8 Simon Fraser (smfr) 2015-05-29 10:52:37 PDT 
https://trac.webkit.org/r184992