Bug 144619

Summary: Rename ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() to {send, cancel}PrepareToSuspend()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, barraclough, cdumez, ddkilzer, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Rename ProcessThrottlerClient functions
none
[Patch] Rename ProcessThrottlerClient functions
none
Patch
none
Patch aestes: review+

Daniel Bates
Reported 2015-05-04 20:00:05 PDT
The names of the functions ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() are misnomers. These functions are called when the ProcessThrottler wants to prepare the process that it manages for suspension and changes it mind, respectively. That is, these functions do not actually correspond to the OS decision to suspend a process or cancel the suspension of a process. We should rename these functions to better describe their purpose.
Attachments
[Patch] Rename ProcessThrottlerClient functions (12.26 KB, patch)
2015-05-04 20:02 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
[Patch] Rename ProcessThrottlerClient functions (13.62 KB, patch)
2015-05-04 20:16 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (13.52 KB, patch)
2015-05-12 15:04 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (13.58 KB, patch)
2015-05-12 15:11 PDT, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-05-04 20:02:34 PDT
Created attachment 252366 [details] [Patch] Rename ProcessThrottlerClient functions I am open to name suggestions.
Radar WebKit Bug Importer
Comment 2 2015-05-04 20:04:34 PDT
<rdar://problem/20812779>
Daniel Bates
Comment 3 2015-05-04 20:16:47 PDT
Created attachment 252367 [details] [Patch] Rename ProcessThrottlerClient functions
Andy Estes
Comment 4 2015-05-06 14:55:30 PDT
Comment on attachment 252367 [details] [Patch] Rename ProcessThrottlerClient functions "process" seems redundant, since in each case that term is already in the class name. What about prepareToSuspend() and cancelPrepareToSuspend()?
Daniel Bates
Comment 5 2015-05-12 15:04:19 PDT
Created attachment 252989 [details] Patch Renamed ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() to {send, cancel}PrepareToSuspend().
Daniel Bates
Comment 6 2015-05-12 15:11:19 PDT
Created attachment 252990 [details] Patch
Andy Estes
Comment 7 2015-05-13 16:34:31 PDT
Comment on attachment 252990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252990&action=review > Source/WebKit2/ChangeLog:10 > + and changes it mind, respectively. That is, these functions do not actually correspond to the OS decision to changes its mind > Source/WebKit2/ChangeLog:11 > + suspend a process or cancel the suspension of a process. We should rename these functions an associated and associated
Daniel Bates
Comment 8 2015-05-13 20:08:56 PDT
Committed r184326: <http://trac.webkit.org/changeset/184326>
Note You need to log in before you can comment on or make changes to this bug.