Bug 144616

Summary:

Record the reference time when Performance is constructed.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, japhet, kling, simon.fraser

Priority:

P2

Keywords:

BlinkMergeCandidate, InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Andreas Kling

Reported 2015-05-04 18:26:53 PDT

<rdar://problem/20249480> Blink does this nice thing where they copy the current time into a member of Performance when it's constructed. Performance::now() can then just compare against that member.

Attachments
Proposed patch (2.75 KB, patch) 2015-05-04 18:45 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2015-05-04 18:28:42 PDT

https://chromium.googlesource.com/chromium/blink.git/+/bea17fc8cb735eaf07bc68e211ba2f30a9298a47 Record the reference time when Performance is constructed. BUG=264490 Review URL: https://chromiumcodereview.appspot.com/23367007 (by simonjam@)

Andreas Kling

Comment 2 2015-05-04 18:45:23 PDT

Created attachment 252362 [details] Proposed patch

Geoffrey Garen

Comment 3 2015-05-04 19:17:32 PDT

Comment on attachment 252362 [details] Proposed patch r=me

WebKit Commit Bot

Comment 4 2015-05-04 21:50:21 PDT

Comment on attachment 252362 [details] Proposed patch Clearing flags on attachment: 252362 Committed r183795: <http://trac.webkit.org/changeset/183795>

WebKit Commit Bot

Comment 5 2015-05-04 21:50:24 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 6 2015-05-05 08:58:04 PDT

This broke a test: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r183803%20(4053)/results.html

Andreas Kling

Comment 7 2015-05-05 09:20:53 PDT

(In reply to comment #6) > This broke a test: > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/ > r183803%20(4053)/results.html Patched up the bots in http://trac.webkit.org/changeset/183808 Thanks for the beep, Simon.

Note You need to log in before you can comment on or make changes to this bug.