| Summary: | Small cleanup in RenderText::computePreferredLogicalWidths() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2015-05-04 18:11:58 PDT
Created attachment 252359 [details]
Patch
Comment on attachment 252359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review > Source/WebCore/rendering/RenderText.cpp:907 > + glyphOverflow.left = firstGlyphLeftOverflow.value(); could use valueOr() Comment on attachment 252359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review > Source/WebCore/rendering/RenderText.cpp:867 > currMinWidth = 0; Unnecessary > Source/WebCore/rendering/RenderText.cpp:877 > currMinWidth = 0; Unnecessary Created attachment 252365 [details]
Patch for landing
Comment on attachment 252365 [details] Patch for landing Rejecting attachment 252365 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 252365, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5014590802886656 Committed r183799: <http://trac.webkit.org/changeset/183799> |