Bug 144615

Summary: Small cleanup in RenderText::computePreferredLogicalWidths()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing commit-queue: commit-queue-

Myles C. Maxfield
Reported 2015-05-04 18:11:58 PDT
Small cleanup in RenderText::computePreferredLogicalWidths()
Attachments
Patch (4.89 KB, patch)
2015-05-04 18:13 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for landing (6.00 KB, patch)
2015-05-04 19:58 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-05-04 18:13:03 PDT
Created attachment 252359 [details] Patch
Myles C. Maxfield
Comment 2 2015-05-04 18:18:17 PDT
Comment on attachment 252359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review > Source/WebCore/rendering/RenderText.cpp:907 > + glyphOverflow.left = firstGlyphLeftOverflow.value(); could use valueOr()
Myles C. Maxfield
Comment 3 2015-05-04 18:41:51 PDT
Comment on attachment 252359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review > Source/WebCore/rendering/RenderText.cpp:867 > currMinWidth = 0; Unnecessary > Source/WebCore/rendering/RenderText.cpp:877 > currMinWidth = 0; Unnecessary
Myles C. Maxfield
Comment 4 2015-05-04 19:58:29 PDT
Created attachment 252365 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-05-04 20:52:27 PDT
Comment on attachment 252365 [details] Patch for landing Rejecting attachment 252365 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 252365, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5014590802886656
Myles C. Maxfield
Comment 6 2015-05-05 00:50:32 PDT
Committed r183799: <http://trac.webkit.org/changeset/183799>
Note You need to log in before you can comment on or make changes to this bug.