Bug 144613

Summary: [CMake] FindGTK3.cmake should not modify the values of build options
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[CMake] FindGTK3.cmake should not modify the values of build options
none
Patch
none
Patch none

Description Michael Catanzaro 2015-05-04 18:03:28 PDT 
FindGTK3.cmake touches both ENABLE_X11_TARGET and ENABLE_WAYLAND_TARGET currently. I didn't realize it was doing that (since it is just a find module and I didn't anticipate it having side effects). Anyway, that won't work as expected anymore since this code runs after the values of those settings have already gone into the FEATURE_DEFINES list, so you would wind up with e.g. ENABLE_X11_TARGET turned off for most of the build, but on in other places (like IDL files).
Comment 1 Martin Robinson 2015-05-04 18:34:38 PDT 
Nice catch.
Comment 2 Michael Catanzaro 2015-05-12 05:36:01 PDT 
Created attachment 252957 [details]
[CMake] FindGTK3.cmake should not modify the values of build options
Comment 3 Michael Catanzaro 2015-06-19 17:36:29 PDT 
I will land this without the dependency on the OS X patch.
Comment 4 Michael Catanzaro 2015-06-19 17:55:04 PDT 
Created attachment 255258 [details]
Patch
Comment 5 Michael Catanzaro 2015-06-19 18:04:35 PDT 
Comment on attachment 255258 [details]
Patch

Typos
Comment 6 Michael Catanzaro 2015-06-19 18:05:41 PDT 
Created attachment 255261 [details]
Patch
Comment 7 WebKit Commit Bot 2015-06-19 19:09:50 PDT 
The commit-queue encountered the following flaky tests while processing attachment 255261 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2015-06-19 19:09:53 PDT 
The commit-queue encountered the following flaky tests while processing attachment 255261 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2015-06-19 19:41:53 PDT 
Comment on attachment 255261 [details]
Patch

Clearing flags on attachment: 255261

Committed r185788: <http://trac.webkit.org/changeset/185788>
Comment 10 WebKit Commit Bot 2015-06-19 19:41:57 PDT 
All reviewed patches have been landed.  Closing bug.