Bug 144586

Summary: Make ExecState::vm() branchless in release builds.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-05-04 10:31:17 PDT
ExecState::vm() is currently implemented as ExecState::callee()->vm(), which is sad because callee() does a null check.
Attachments
Patch (1.25 KB, patch)
2015-05-04 10:31 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-04 10:31:50 PDT
Created attachment 252320 [details] Patch
Geoffrey Garen
Comment 2 2015-05-04 10:47:23 PDT
Comment on attachment 252320 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-05-04 11:46:59 PDT
Comment on attachment 252320 [details] Patch Clearing flags on attachment: 252320 Committed r183753: <http://trac.webkit.org/changeset/183753>
WebKit Commit Bot
Comment 4 2015-05-04 11:47:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.