Bug 144578

Summary: Add missing vtable override specifiers under Source/WebCore/html
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, dino, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2015-05-04 09:17:13 PDT 
Add missing vtable override specifiers under Source/WebCore/html
Comment 1 Zan Dobersek 2015-05-04 09:19:55 PDT 
Created attachment 252314 [details]
Patch
Comment 2 Daniel Bates 2015-05-04 10:19:44 PDT 
Comment on attachment 252314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review

> Source/WebCore/ChangeLog:1
> +2015-05-04  Žan Doberšek  <zdobersek@igalia.com>

There seems to be some character encoding issue with respect to the characters on this line.
Comment 3 Daniel Bates 2015-05-04 10:20:50 PDT 
Comment on attachment 252314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review

> Source/WebCore/html/track/TrackListBase.h:54
> +    virtual EventTargetInterface eventTargetInterface() const override = 0;

There should not be an override specifier here.
Comment 4 Daniel Bates 2015-05-04 10:30:33 PDT 
Comment on attachment 252314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review

>> Source/WebCore/html/track/TrackListBase.h:54
>> +    virtual EventTargetInterface eventTargetInterface() const override = 0;
> 
> There should not be an override specifier here.

Never mind. As indicated by the comment on line 53, this is a redeclaration of EventTarget::eventTargetInterface().
Comment 5 Zan Dobersek 2015-05-05 23:13:09 PDT 
(In reply to comment #2)
> Comment on attachment 252314 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252314&action=review
> 
> > Source/WebCore/ChangeLog:1
> > +2015-05-04  Žan Doberšek  <zdobersek@igalia.com>
> 
> There seems to be some character encoding issue with respect to the
> characters on this line.

This appears to be a bug in PrettyPatch.
Comment 6 Zan Dobersek 2015-05-05 23:24:43 PDT 
Comment on attachment 252314 [details]
Patch

Clearing flags on attachment: 252314

Committed r183858: <http://trac.webkit.org/changeset/183858>
Comment 7 Zan Dobersek 2015-05-05 23:24:51 PDT 
All reviewed patches have been landed.  Closing bug.