Bug 144578

Summary: Add missing vtable override specifiers under Source/WebCore/html
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, dino, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2015-05-04 09:17:13 PDT
Add missing vtable override specifiers under Source/WebCore/html
Attachments
Patch (4.09 KB, patch)
2015-05-04 09:19 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-05-04 09:19:55 PDT
Created attachment 252314 [details] Patch
Daniel Bates
Comment 2 2015-05-04 10:19:44 PDT
Comment on attachment 252314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review > Source/WebCore/ChangeLog:1 > +2015-05-04 Žan Doberšek <zdobersek@igalia.com> There seems to be some character encoding issue with respect to the characters on this line.
Daniel Bates
Comment 3 2015-05-04 10:20:50 PDT
Comment on attachment 252314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review > Source/WebCore/html/track/TrackListBase.h:54 > + virtual EventTargetInterface eventTargetInterface() const override = 0; There should not be an override specifier here.
Daniel Bates
Comment 4 2015-05-04 10:30:33 PDT
Comment on attachment 252314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252314&action=review >> Source/WebCore/html/track/TrackListBase.h:54 >> + virtual EventTargetInterface eventTargetInterface() const override = 0; > > There should not be an override specifier here. Never mind. As indicated by the comment on line 53, this is a redeclaration of EventTarget::eventTargetInterface().
Zan Dobersek
Comment 5 2015-05-05 23:13:09 PDT
(In reply to comment #2) > Comment on attachment 252314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252314&action=review > > > Source/WebCore/ChangeLog:1 > > +2015-05-04 Žan Doberšek <zdobersek@igalia.com> > > There seems to be some character encoding issue with respect to the > characters on this line. This appears to be a bug in PrettyPatch.
Zan Dobersek
Comment 6 2015-05-05 23:24:43 PDT
Comment on attachment 252314 [details] Patch Clearing flags on attachment: 252314 Committed r183858: <http://trac.webkit.org/changeset/183858>
Zan Dobersek
Comment 7 2015-05-05 23:24:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.