Bug 144564

Summary: Remove dead code from TestInvocationCairo.cpp
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-05-04 03:56:15 PDT
void TestInvocation::dumpPixelsAndCompareWithExpected(WKImageRef wkImage, WKArrayRef repaintRects) has "PLATFORM(EFL) || PLATFORM(GTK)" and "else" implementation. But there isn't any WK2 Cairo platform different from EFL or GTK, so the else case is simply dead code, let's remove it.
Attachments
Patch (1.75 KB, patch)
2015-05-04 03:58 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-05-04 03:58:37 PDT
Created attachment 252304 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-04 08:22:01 PDT
Comment on attachment 252304 [details] Patch Clearing flags on attachment: 252304 Committed r183745: <http://trac.webkit.org/changeset/183745>
WebKit Commit Bot
Comment 3 2015-05-04 08:22:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.