Bug 144562

Summary: Make all FrameLoadState data members private
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit2Assignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sungmann Cho 2015-05-03 18:30:22 PDT 
Previously, all of the data members in FrameLoadState were public and accessed directly from outside the class.
But these should all be private as noted in FrameLoadState.h for better encapsulation.
Comment 1 Sungmann Cho 2015-05-03 18:37:25 PDT 
Created attachment 252297 [details]
Patch
Comment 2 Darin Adler 2015-05-04 15:58:58 PDT 
Comment on attachment 252297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252297&action=review

> Source/WebKit2/UIProcess/FrameLoadState.h:54
> +    const State& state() const { return m_state; }

I think the type here should just be State since it’s a small scalar.
Comment 3 Sungmann Cho 2015-05-04 16:17:21 PDT 
Created attachment 252348 [details]
Patch
Comment 4 Sungmann Cho 2015-05-04 16:18:32 PDT 
Addressed darin's comments.
Comment 5 WebKit Commit Bot 2015-05-05 09:36:10 PDT 
Comment on attachment 252348 [details]
Patch

Clearing flags on attachment: 252348

Committed r183813: <http://trac.webkit.org/changeset/183813>
Comment 6 WebKit Commit Bot 2015-05-05 09:36:14 PDT 
All reviewed patches have been landed.  Closing bug.