Bug 144562

Summary: Make all FrameLoadState data members private
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit2Assignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sungmann Cho
Reported 2015-05-03 18:30:22 PDT
Previously, all of the data members in FrameLoadState were public and accessed directly from outside the class. But these should all be private as noted in FrameLoadState.h for better encapsulation.
Attachments
Patch (3.79 KB, patch)
2015-05-03 18:37 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2015-05-04 16:17 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-05-03 18:37:25 PDT
Created attachment 252297 [details] Patch
Darin Adler
Comment 2 2015-05-04 15:58:58 PDT
Comment on attachment 252297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252297&action=review > Source/WebKit2/UIProcess/FrameLoadState.h:54 > + const State& state() const { return m_state; } I think the type here should just be State since it’s a small scalar.
Sungmann Cho
Comment 3 2015-05-04 16:17:21 PDT
Created attachment 252348 [details] Patch
Sungmann Cho
Comment 4 2015-05-04 16:18:32 PDT
Addressed darin's comments.
WebKit Commit Bot
Comment 5 2015-05-05 09:36:10 PDT
Comment on attachment 252348 [details] Patch Clearing flags on attachment: 252348 Committed r183813: <http://trac.webkit.org/changeset/183813>
WebKit Commit Bot
Comment 6 2015-05-05 09:36:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.