Web Inspector: Exception under ContentViewContainer _disassociateFromContentView

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

_disassociateFromContentView is being passed a BackForwardEntry instead of a ContentView in one case. There is also an associated logic error.

I think this was masked by the fact that _disassociateFromContentView wouldn't call closed() if the representedObject was null on the passed object. Since BackForwardEntry doesn't have a representedObject, it would always abort early. This would lead to memory leaks too.

[Radar WebKit Bug Importer]

<rdar://problem/20793755>

[Timothy Hatcher]

Created attachment 252268 [details]
Patch

[Brian Burg]

Comment on attachment 252268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252268&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:182
> +                this._disassociateFromContentView(removedEntries[i].contentView);

Would be prudent to add a type test for the method's parameter. (The method name is really clear, but this still slipped up.)

[WebKit Commit Bot]

Comment on attachment 252268 [details]
Patch

Clearing flags on attachment: 252268

Committed r183733: <http://trac.webkit.org/changeset/183733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Timothy Hatcher]

Comment on attachment 252268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252268&action=review

>> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:182
>> +                this._disassociateFromContentView(removedEntries[i].contentView);
> 
> Would be prudent to add a type test for the method's parameter. (The method name is really clear, but this still slipped up.)

I think this happened during refactoring when you added BackForwardEntry into the mix instead of dealing with ContentViews directly. It was just masked by an early return that I recently removed.

But yes, an assert for the type would normally be good.