Bug 144510

Summary: Expose API in WKBackForwardListRef for removing a back forward list item
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, ap, beidson, commit-queue, mitz, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review-

Description Ada Chan 2015-05-01 17:30:14 PDT 
There's currently no method to remove an item in WebBackForwardList, so we'll have to add one.

This is needed for <rdar://problem/20681226>
Comment 1 Ada Chan 2015-05-04 15:02:15 PDT 
Created attachment 252336 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-04 15:05:55 PDT 
Attachment 252336 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebBackForwardList.cpp:328:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-05-04 15:31:46 PDT 
Comment on attachment 252336 [details]
Patch

We feel that the WebBackForwardList in WK1 being mutable by the client was a mistake and therefore we've willfully *not* added any mutability to the WK2 list.

It's been asked multiple times, but we've always found a different solution for whoever has needed it.

Can you describe more why we *have* to do this?
Comment 4 Ada Chan 2015-05-04 16:18:11 PDT 
We'll try to accomplish what we need without this change.  Closing the bug.