Bug 144493

Summary:

Stop using deprecated AVKit SPI for enter and exit fullscreen.

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

Media

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jeremy Jones 2015-05-01 10:38:29 PDT

Stop using deprecated AVKit SPI for enter and exit fullscreen.

Comment 1 Jeremy Jones 2015-05-01 10:41:06 PDT

rdar://problem/20733676

Comment 2 Jeremy Jones 2015-05-01 10:42:20 PDT

Created attachment 252157 [details]
Patch

Comment 3 WebKit Commit Bot 2015-05-01 10:44:17 PDT

Attachment 252157 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1043:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1098:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 WebKit Commit Bot 2015-05-01 14:19:22 PDT

Comment on attachment 252157 [details]
Patch

Clearing flags on attachment: 252157

Committed r183690: <http://trac.webkit.org/changeset/183690>

Comment 5 WebKit Commit Bot 2015-05-01 14:19:25 PDT

All reviewed patches have been landed.  Closing bug.