Bug 144462

Summary: Move all of the branchIs<type> helpers from SpeculativeJIT into AssemblyHelpers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 144396    
Attachments:
Description Flags
it begins
none
almost done
none
the patch
none
the patch
ggaren: review+
the patch mark.lam: review+

Filip Pizlo
Reported 2015-04-30 11:37:29 PDT
Patch forthcoming.
Attachments
it begins (21.92 KB, patch)
2015-04-30 11:49 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost done (51.19 KB, patch)
2015-04-30 16:13 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (57.16 KB, patch)
2015-04-30 16:27 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (57.17 KB, patch)
2015-04-30 16:31 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
the patch (57.17 KB, patch)
2015-04-30 16:50 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-04-30 11:49:44 PDT
Created attachment 252076 [details] it begins
Filip Pizlo
Comment 2 2015-04-30 16:13:18 PDT
Created attachment 252102 [details] almost done
Filip Pizlo
Comment 3 2015-04-30 16:27:09 PDT
Created attachment 252108 [details] the patch
Filip Pizlo
Comment 4 2015-04-30 16:30:34 PDT
Comment on attachment 252108 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=252108&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968 > - fastFalse.append(branchNotString(rightRegs.payloadGPR())); > + fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR())); This looks busted.
Filip Pizlo
Comment 5 2015-04-30 16:30:46 PDT
(In reply to comment #4) > Comment on attachment 252108 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252108&action=review > > > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968 > > - fastFalse.append(branchNotString(rightRegs.payloadGPR())); > > + fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR())); > > This looks busted. Fixed locally.
Filip Pizlo
Comment 6 2015-04-30 16:31:22 PDT
Created attachment 252110 [details] the patch
Geoffrey Garen
Comment 7 2015-04-30 16:48:29 PDT
Comment on attachment 252110 [details] the patch r=me if unbusted
Filip Pizlo
Comment 8 2015-04-30 16:50:01 PDT
Created attachment 252114 [details] the patch More build/correctness fixing.
Mark Lam
Comment 9 2015-04-30 17:03:25 PDT
Comment on attachment 252114 [details] the patch r=me too
Filip Pizlo
Comment 10 2015-04-30 17:08:26 PDT
Landed in http://trac.webkit.org/changeset/183656
Note You need to log in before you can comment on or make changes to this bug.