Bug 144462

Summary: Move all of the branchIs<type> helpers from SpeculativeJIT into AssemblyHelpers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 144396    
Attachments:
Description Flags
it begins
none
almost done
none
the patch
none
the patch
ggaren: review+
the patch mark.lam: review+

Description Filip Pizlo 2015-04-30 11:37:29 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-04-30 11:49:44 PDT 
Created attachment 252076 [details]
it begins
Comment 2 Filip Pizlo 2015-04-30 16:13:18 PDT 
Created attachment 252102 [details]
almost done
Comment 3 Filip Pizlo 2015-04-30 16:27:09 PDT 
Created attachment 252108 [details]
the patch
Comment 4 Filip Pizlo 2015-04-30 16:30:34 PDT 
Comment on attachment 252108 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252108&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968
> -    fastFalse.append(branchNotString(rightRegs.payloadGPR()));
> +    fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR()));

This looks busted.
Comment 5 Filip Pizlo 2015-04-30 16:30:46 PDT 
(In reply to comment #4)
> Comment on attachment 252108 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252108&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968
> > -    fastFalse.append(branchNotString(rightRegs.payloadGPR()));
> > +    fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR()));
> 
> This looks busted.

Fixed locally.
Comment 6 Filip Pizlo 2015-04-30 16:31:22 PDT 
Created attachment 252110 [details]
the patch
Comment 7 Geoffrey Garen 2015-04-30 16:48:29 PDT 
Comment on attachment 252110 [details]
the patch

r=me if unbusted
Comment 8 Filip Pizlo 2015-04-30 16:50:01 PDT 
Created attachment 252114 [details]
the patch

More build/correctness fixing.
Comment 9 Mark Lam 2015-04-30 17:03:25 PDT 
Comment on attachment 252114 [details]
the patch

r=me too
Comment 10 Filip Pizlo 2015-04-30 17:08:26 PDT 
Landed in http://trac.webkit.org/changeset/183656