Bug 144453

Summary:

Decrease minimum Vector size

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

Web Template Framework

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, kling, slewis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

144594

Bug Blocks:

Attachments:

Description	Flags
Patch	none
results of run-jsc-benchmarks	none

Description Alex Christensen 2015-04-30 10:04:19 PDT

jsc benchmarks indicate that shrinking small Vectors doesn't slow things down much, but we'll probably save memory.

Comment 1 Alex Christensen 2015-04-30 10:05:54 PDT

Created attachment 252065 [details]
Patch

Comment 2 Alex Christensen 2015-04-30 10:06:59 PDT

Created attachment 252066 [details]
results of run-jsc-benchmarks

Comment 3 Andreas Kling 2015-04-30 17:51:12 PDT

Comment on attachment 252065 [details]
Patch

Ok, let's do it. r=me

Comment 4 WebKit Commit Bot 2015-04-30 18:39:43 PDT

Comment on attachment 252065 [details]
Patch

Clearing flags on attachment: 252065

Committed r183661: <http://trac.webkit.org/changeset/183661>

Comment 5 WebKit Commit Bot 2015-04-30 18:39:47 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 WebKit Commit Bot 2015-05-04 13:40:10 PDT

Re-opened since this is blocked by bug 144594

Comment 7 Alex Christensen 2015-05-05 00:22:24 PDT

It is very strange that this increased memory usage, but the bot doesn't lie.  We could look into this more closely, but that would require much more than this one-number change.